Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ESCItem that is a trigger should not capture input events #516

Merged
merged 1 commit into from
Mar 1, 2022
Merged

fix: ESCItem that is a trigger should not capture input events #516

merged 1 commit into from
Mar 1, 2022

Conversation

bolinfest
Copy link
Contributor

@bolinfest bolinfest mentioned this pull request Mar 1, 2022
Closed
@bolinfest
Copy link
Contributor Author

If you trace through the code, in ESCItem._ready(), signals such as mouse_left_clicked_item are wired up only when !is_trigger. Therefore, in ESCItem._unhandled_input(), there is no reason to exercise the emit_signal calls when is_trigger is true. At least in this case, it also appears that the get_tree().set_input_as_handled() calls are working against us, so we should just bail out altogether.

@bolinfest bolinfest mentioned this pull request Mar 1, 2022
Merged
@balloonpopper
Copy link
Collaborator

Confirmed that this fixes the issue in the new version of room 7 (#514)

BHSDuncan
BHSDuncan approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@BHSDuncan BHSDuncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though the other guys will be able to better test this.

dploeger
dploeger approved these changes Mar 1, 2022
View reviewed changes
Copy link
Collaborator

@dploeger dploeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. Thanks a lot. 🎁

@dploeger dploeger merged commit 0570edc into godot-escoria:develop Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BHSDuncan BHSDuncan BHSDuncan approved these changes

@dploeger dploeger dploeger approved these changes

@StraToN StraToN Awaiting requested review from StraToN StraToN is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't walk to a point within a CollisionPolygon2D
4 participants
@bolinfest @balloonpopper @dploeger @BHSDuncan