refactor: Whitespace removal from all .gd files #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BHSDuncan
approved these changes
Feb 15, 2022
StraToN
approved these changes
Feb 15, 2022
|
I would have preferred a rebase instead of merging HEAD into this branch so that the PR doesn't hold code that's already in the target branch. |
Agreed as well. Can you maybe rebase it on develop? |
balloonpopper
force-pushed
the
whitespace_removal
branch
from
979d7d6 to
4bb176c
Compare
|
@StraToN @dploeger @BHSDuncan should be good now. |
|
lgtm |
balloonpopper
force-pushed
the
whitespace_removal
branch
from
4bb176c to
fe40138
Compare
balloonpopper
force-pushed
the
whitespace_removal
branch
from
fe40138 to
da744fd
Compare
|
All good ! Thanks! |
bolinfest
added a commit
to bolinfest/escoria-demo-game
that referenced
this pull request
Mar 2, 2022
Not sure why these files were not included in godot-escoria#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e 's/ *$//g' ```
bolinfest
added a commit
to bolinfest/escoria-demo-game
that referenced
this pull request
Mar 2, 2022
Not sure why these files were not included in godot-escoria#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
bolinfest
added a commit
to bolinfest/escoria-demo-game
that referenced
this pull request
Mar 3, 2022
Not sure why these files were not included in godot-escoria#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
bolinfest
added a commit
to bolinfest/escoria-demo-game
that referenced
this pull request
Mar 7, 2022
Not sure why these files were not included in godot-escoria#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
bolinfest
added a commit
to bolinfest/escoria-demo-game
that referenced
this pull request
Mar 7, 2022
Not sure why these files were not included in godot-escoria#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
StraToN
pushed a commit
that referenced
this pull request
Mar 7, 2022
Not sure why these files were not included in #494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
StraToN
pushed a commit
to godot-escoria/escoria-ui-simplemouse
that referenced
this pull request
Mar 7, 2022
Not sure why these files were not included in godot-escoria/escoria-demo-game#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
StraToN
pushed a commit
to godot-escoria/escoria-ui-9verbs
that referenced
this pull request
Mar 7, 2022
Not sure why these files were not included in godot-escoria/escoria-demo-game#494. Created this diff by running the following on Linux: ``` find -name \*.gd | xargs sed -i -e "s/[[:space:]]\+$//g" ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Godot 3.4.2 automatically removes whitespace from gd files when the project is run, this PR is to fix all files.
After whitespace removal and testing the demo, Godot changed 2 files again, so these were recommitted. No further changes occurred after opening every room in the demo.