Fix: use Escoria plugin version from plugin.cfg in savegames #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes the bug with the infinite loop, however I did find a edge case that isn't handled. I manually deleted save games 1-3 but still had save game 4 in the folder. |
|
Good point. I'll add a check to manage this case. |
dploeger
requested changes
Feb 12, 2022
BHSDuncan
approved these changes
Feb 13, 2022
StraToN
force-pushed
the
fix-savegames-esc-version
branch
from
40ac083 to
7de0da6
Compare
+ Fix issue happening when save folder misses some savegames for slots
StraToN
force-pushed
the
fix-savegames-esc-version
branch
from
7de0da6 to
feab576
Compare
BHSDuncan
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save manager used escoria.ESCORIA_VERSION constant value, which is now incorrect. We now use plugin.cfg's version instead.