feat: add esc_current_scene reserved global #474
Conversation
…s' handling for rooms with addition of ESCRoomManager and elimination of string literals across multiple files
| @@ -0,0 +1,32 @@ | |||
| extends Object | |||
| class_name ESCRoomManager | |||
There was a problem hiding this comment.
I am not so fond of the name of this class: ESCRoomManager seems to imply this class manages rooms, but this is not true as it's just an enum entries holder. Would ESCReservedGlobals fit instead?
There was a problem hiding this comment.
Actually, my idea was that this manager would also change the room for example. Also, why's the GLOBAL_ANIMATION_RESOURCES here? That doesn't have to do anything with rooms if I'm not mistaken.
There was a problem hiding this comment.
Ah, I see. You saw it in ESCRoom and put it here. It's actually the global cache of the current animation resource of the player, so it doesn't really fit here. Hm... maybe ESCPlayer? I'm not 100% sure.
There was a problem hiding this comment.
Actually, my idea was that this manager would also change the room for example
Can you give more precisions on this?
There was a problem hiding this comment.
Ah, I see. You saw it in ESCRoom and put it here. It's actually the global cache of the current animation resource of the player, so it doesn't really fit here. Hm... maybe ESCPlayer? I'm not 100% sure.
Yeah, you got it. It's also only ever used in ESCRoom, it seems. But I'm happy to put it wherever you deem best.
There was a problem hiding this comment.
Isn't it also used in the set_animations command? 🤔
There was a problem hiding this comment.
Actually, good catch. I didn't see it because it's actually referenced by a one-off constant in globals_manager, so I'll need to fix that anyway.
But like I said: I'll put the definition in whichever class you prefer!
| ) | ||
| _reserved_globals[key] = value | ||
| _globals[key] = value | ||
| emit_signal("global_changed", key, _globals[key], value) |
There was a problem hiding this comment.
I'd say, you should only emit the signal, if the value is not null.
| @@ -0,0 +1,32 @@ | |||
| extends Object | |||
| class_name ESCRoomManager | |||
There was a problem hiding this comment.
Actually, my idea was that this manager would also change the room for example. Also, why's the GLOBAL_ANIMATION_RESOURCES here? That doesn't have to do anything with rooms if I'm not mistaken.
| @@ -0,0 +1,32 @@ | |||
| extends Object | |||
| class_name ESCRoomManager | |||
There was a problem hiding this comment.
Ah, I see. You saw it in ESCRoom and put it here. It's actually the global cache of the current animation resource of the player, so it doesn't really fit here. Hm... maybe ESCPlayer? I'm not 100% sure.
| @@ -54,7 +54,9 @@ func _on_button_pressed(): | |||
| # automatic transitions. | |||
| # If FORCE_LAST_SCENE_NULL is True when change_scene starts: | |||
| # - ESC_LAST_SCENE is set to empty | |||
| escoria.globals_manager.set_global("FORCE_LAST_SCENE_NULL", true, true) | |||
| escoria.globals_manager.set_global( \ | |||
There was a problem hiding this comment.
I'd better format that like
escoria.globals_manager.set_global(
escoria.room_manager.GLOBAL_FORCE_LAST_SCENE_NULL,
true,
true
)There was a problem hiding this comment.
Ah, you don't need the \ in the first line. Also, please put the closing bracket into the next line all to the left aligned with the command itself.
| @@ -54,7 +54,9 @@ func _on_button_pressed(): | |||
| # automatic transitions. | |||
| # If FORCE_LAST_SCENE_NULL is True when change_scene starts: | |||
| # - ESC_LAST_SCENE is set to empty | |||
| escoria.globals_manager.set_global("FORCE_LAST_SCENE_NULL", true, true) | |||
| escoria.globals_manager.set_global( \ | |||
There was a problem hiding this comment.
Ah, you don't need the \ in the first line. Also, please put the closing bracket into the next line all to the left aligned with the command itself.
|
Oh, I forgot: Great work. 🎁 :) |
Thank you! Hopefully I can always produce good work! |
|
All good for me. Good remarks and great addition, great work! Thanks a lot! |
Co-authored-by: Duncan Brown <[email protected]>
New reserved global to hold current scene global ID to allow for flexibility in ESC scripts.
Also refactor reserved globals' handling for rooms with addition of ESCRoomManager and the elimination of string literals across multiple files. Allows for less chance of accidental errors as opposed to using string literals everywhere. As well, this encapsulates room-specific reserved globals and will serve as the basis for more room-specific behaviour management.