Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Huge cleanup #420

Merged
merged 2 commits into from
Oct 25, 2021
Merged

fix: Huge cleanup #420

merged 2 commits into from
Oct 25, 2021

Conversation

dploeger
Copy link
Collaborator

Removing template-scenes
Moving stuff game/ui/common to ui_library
Removing stuff that is not required anymore
Made room selector configurable

Fixes godot-escoria/escoria-issues#44

Removing template-scenes
Moving stuff game/ui/common to ui_library
Removing stuff that is not required anymore
Made room selector configurable
@dploeger dploeger requested a review from StraToN October 22, 2021 14:09
@StraToN
Copy link
Collaborator

StraToN commented Oct 25, 2021

Great cleanup! Thanks!
I think that the game/ui* folder is also not required anymore as it only contains .import files. Can you please remove it?

Copy link
Collaborator

@StraToN StraToN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove res://game/ui folder, now useless.

@dploeger
Copy link
Collaborator Author

Please remove res://game/ui folder, now useless.

Hm... It is already gone on my side. Maybe the .import files on your side are older ignored ones?

@StraToN
Copy link
Collaborator

StraToN commented Oct 25, 2021

Please remove res://game/ui folder, now useless.

Hm... It is already gone on my side. Maybe the .import files on your side are older ignored ones?

Ah that's possible indeed. Looks good to me then! Thanks!

@StraToN StraToN merged commit 94d86d2 into develop Oct 25, 2021
@StraToN StraToN deleted the issue-44 branch October 25, 2021 06:59
balloonpopper pushed a commit to balloonpopper/escoria-demo-game that referenced this pull request Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate game/ui/commons into escoria-core
2 participants