Missing background info and k8s configs for examples

[peterkuiper]

I think a bit of background info about what actually happens on SIGTERM and maybe some example k8s yaml files to get people going would be great (readinessProbe, livenessProbe and terminationGracePeriodSeconds). Your blog post explains things a bit more in depth: things get confusing :)

Maybe even an example of it working in action with minikube would be great. How can you confirm that everything is working correctly?

Either way, great module. I replaced our custom code (in the end did the same thing but with more clutter). We added a const serverListenAsync = promisify(server.listen.bind(server)) so server startup steps can be nicely chained (ie, db connection, redis etc).

Does godaddy use terminus in production? Maybe there are some tips and tricks you can share.

[gergelyke]

Hi Peter,

yeah, that makes sense, I'll work on that!

Yes, we use it in production.

[peterkuiper]

If you need any help, please let me know!

[gergelyke]

Thanks @peterkuiper - once I have a PR ready, I will send it your way!

[gergelyke]

@peterkuiper managed to put together a first draft: #58

please let me know what you'd change!

[gergelyke]

closing as #58 is merged

[peterkuiper]

@gergelyke Sorry for the late response: LGTM!

[gergelyke]

cool, thanks @peterkuiper!