Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve a11y on checkbox #729

Open
jlemay-godaddy opened this issue Nov 11, 2021 · 0 comments
Open

Improve a11y on checkbox #729

jlemay-godaddy opened this issue Nov 11, 2021 · 0 comments
Labels
[Priority] High This issue/pull request needs resolving before the next release [Type] a11y Issues/PRs related to accessibility [Type] Bug Something that is not working as expected [Type] Design Issues/PRs related to improving design

Comments

@jlemay-godaddy
Copy link
Contributor

Describe the bug:
Right now, we are hidding the <input> with CSS when using checkboxes, and create a fake checkbox with SVG on the ::before element inside the <label>. We are unable to enter the label using the keyboard, and even if we are forcing the tabbing using tabIndex=0 we are not able to toggle the checkbox using the space or enter key.

We should revert this and do something more accessible like in the Twenty-Twenty-One theme.

Also, I haven't tested yet, but I assume we are having the same problem with Radio inputs.

@jlemay-godaddy jlemay-godaddy added [Type] Bug Something that is not working as expected [Type] Design Issues/PRs related to improving design labels Nov 11, 2021
@EvanHerman EvanHerman added [Priority] High This issue/pull request needs resolving before the next release [Type] a11y Issues/PRs related to accessibility labels Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] High This issue/pull request needs resolving before the next release [Type] a11y Issues/PRs related to accessibility [Type] Bug Something that is not working as expected [Type] Design Issues/PRs related to improving design
Projects
None yet
Development

No branches or pull requests

2 participants