Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid YAML parses successfully: indentation changed after scalar value #407

Closed
braydonk opened this issue Oct 16, 2023 · 3 comments · Fixed by #504
Closed

Invalid YAML parses successfully: indentation changed after scalar value #407

braydonk opened this issue Oct 16, 2023 · 3 comments · Fixed by #504
Labels
bug Something isn't working high priority

Comments

@braydonk
Copy link
Contributor

braydonk commented Oct 16, 2023 •
edited
Loading

Describe the bug
The following YAML is invalid:

a: 'b'
  b: 1

It is invalid because the indentation level has changed after a scalar value, which doesn't make sense.

To Reproduce
https://go.dev/play/p/WkfZUGjlNY6

Expected behavior
This yaml should be rejected with an error.

Screenshots
If applicable, add screenshots to help explain your problem.

Version Variables

  • Go version: 1.21
  • go-yaml's Version: v1.11.2

Additional context
In the playground, I show that yaml.v3 correctly rejects the invalid yaml.
@braydonk braydonk added the bug Something isn't working label Oct 16, 2023
@braydonk braydonk mentioned this issue Oct 16, 2023
Closed
@braydonk braydonk changed the title Invalid YAML is accepted in Unmarshal Invalid YAML parses successfully: indentation changed after scalar value Oct 16, 2023
@braydonk
Copy link
Contributor Author

Very likely #358 is related

@goccy
Copy link
Owner

goccy commented Oct 19, 2023

Thank you for your reporting. I'll try to fix this problem.

@mx-psi mx-psi mentioned this issue Jul 16, 2024
Closed
@goccy goccy mentioned this issue Nov 3, 2024
Merged
@goccy goccy closed this as completed in #504 Nov 3, 2024
@goccy
Copy link
Owner

goccy commented Nov 3, 2024

@braydonk Thank you for your reporting ! Also, Sorry for the late response. I've fixed this problem with latest release !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix invalid map token goccy/go-yaml
2 participants
@goccy @braydonk