Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the image footer optional #11

Closed
sluongng opened this issue Jan 12, 2021 · 4 comments
Closed

Make the image footer optional #11

sluongng opened this issue Jan 12, 2021 · 4 comments

Comments

@sluongng
Copy link

This is a very cool package.

It would be a lot easier to adopt if you make the footer(twitter/wechat) optional.

Better yet, provide a config for user to either turn off the footer or customize their own during deployment.

@zigo101
Copy link
Collaborator

zigo101 commented Jan 12, 2021

Is it ok to add a -simplefooter option, if which is specified, a simple footer like "Generated with Golds v0.1.7. (GOOS=linux GOARCH=amd64)" is used instead?

@sluongng
Copy link
Author

Yeah something like that would be much preferable.

Just keep in mind that people can always make a fork and change up the code. But having a customizable options would make it easier to use the current package as-is.

@zigo101
Copy link
Collaborator

zigo101 commented Jan 12, 2021

@sluongng
Thanks for the suggestion.

The project will use a configuration file to customize generation outputs when most of planned features are implemented and most command line options are stabilized. Since then, local go.lds files and a global one will be looked up and viewed as configuration files. (I opened another issue for this.)

Currently, (experimental) command line options are preferred. Forks are welcome if these options don't satisfy specific needs.

A -footer option will be added soon afterwards.

@zigo101
Copy link
Collaborator

zigo101 commented Jan 17, 2021

A -footer-showing=verbose+qrcode|verbose|simple|none cli option is added in v0.1.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants