bump actions/checkout@v3 and actions/setup-go@v3 #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Nov 29, 2022
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-go@v2 | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-go@v3 | ||
| with: | ||
| go-version: ${{ matrix.go }} |
There was a problem hiding this comment.
How about adding cache: true here?
There was a problem hiding this comment.
I don't know why, but actions/setup-go fails with Go 1.14 when cache: true is enabled.
https://github.com/go-sql-driver/mysql/actions/runs/3574840133/jobs/6010627696
There was a problem hiding this comment.
cache option in setup-go uses go.sum file. So we can not use it for now.
I don't know why, but some jobs fail with "Could not get cache folder paths". This reverts commit 185228e.
methane
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix warnings in the GitHub Actions workflow.
For example: https://github.com/go-sql-driver/mysql/actions/runs/3562298266
Checklist