Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undefined: sql.NullTime #1214

Closed
paramjeetkumar7297470 opened this issue May 18, 2021 · 8 comments
Closed

undefined: sql.NullTime #1214

paramjeetkumar7297470 opened this issue May 18, 2021 · 8 comments

Comments

@paramjeetkumar7297470
Copy link

paramjeetkumar7297470 commented May 18, 2021

github.com/go-sql-driver/mysql

../../github.com/go-sql-driver/mysql/nulltime.go:36:15: undefined: sql.NullTime
Makefile:14: recipe for target 'go-get-packages' failed

I was making build and started facing this problem. And I think, it is occur due to recent update in nulltime.go file.

Please help..

@shogo82148
Copy link
Contributor

@ionutz-zumata
Copy link

@paramjeetkumar7297470 - if your pipeline is using golang version 1.12 or lower, you must upgrade it to at least 1.13.

@alimoli
Copy link

alimoli commented May 19, 2021

@paramjeetkumar7297470 - if your pipeline is using golang version 1.12 or lower, you must upgrade it to at least 1.13.

Could we know the reason for this issue?
I am using the version v.1.4.1.

Update
I have just seen the PR merge (#1211).

@ionutz-zumata
Copy link

@alimoli - please don't kill the messenger:). I just have the same issue few moments a go, and I saw the PR you are referring to was merged to the latest release.

@chriskarlin
Copy link

I am having the same issue with an automated build on circleci that is running version 1.13.. Is there any update on this?

@ionutz-zumata
Copy link

@chriskarlin 1.13 shouldn't have this issue... I tested myself - upgrading from 1.12 to 1.13 solved the issue

@chriskarlin
Copy link

@chriskarlin 1.13 shouldn't have this issue... I tested myself - upgrading from 1.12 to 1.13 solved the issue

You are correct. Was looking at the wrong file.

@zihengCat
Copy link
Contributor

See #960.

Go 1.13 added sql.NullTime, the driver is target to support Go 1.13 or higher.

This issue could be closed safely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants