-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
args do not support uint64 #1089
Comments
We are using I am feeling the combination triggers the call path above, and that is why many people do not see the error before.. |
In If no instrument is used, it would fall back to |
send out a fix in #1090 |
Looks like it can be closed. |
Can we please cut a release for the patch? We still accidentally get upgraded. |
+1 This bug has caused issues for my team. Cutting a new release would be great |
Issue description
We upgrade the driver from 1.4.1 to 1.5, and all the select statements with
uint64
as args are failing.I think the issue is introduced by #838., which would fail https://github.com/golang/go/blob/master/src/database/sql/convert.go#L83.
For
In 1.4,
nv.Value
would be casted toint64
, sodriver.IsValue
returns true. Now,nv.Value
would remainuint64
, anddriver.IsValue
would return false, and cause the error above.Error log
The text was updated successfully, but these errors were encountered: