Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine a policy for handling imported keys #52

Closed
ericchiang opened this issue Apr 27, 2020 · 1 comment
Closed

Determine a policy for handling imported keys #52

ericchiang opened this issue Apr 27, 2020 · 1 comment

Comments

@ericchiang
Copy link
Collaborator

These were explicitly left out of the API since hardware bound keys are a much stronger security assertion if they never leave the key and you can prove that they're actually bound to hardware. They also make things harder because of they won't have an attestation certificate for us to get hints about PIN policy.

Consider documenting that imported keys aren't supported or explicitly handling them. Either way it's unlikely we'll provide an API to import keys.

For KeyAuth, the API to handle imported keys might look like:

type KeyAuth struct {
    PIN       string
    PINPrompt func() (string, error)

    // ImportedKeyPINPolicy is required for interacting with other tools that import
    // keys that take a PIN.
    //
    // If a key was generated by this package, this value doesn't need to be set.
    ImportedKeyPINPolicy PINPolicy
}
@ericchiang
Copy link
Collaborator Author

Fixed by #65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant