-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop mirroring of root directory to v3 #467
Comments
Agreed; we went down this path when modules were new, and I was having trouble figuring out the right way to version. Anyone familiar with versioning in go modules (and ideally with legacy versioning experience too) would be welcome to propose a path forward here. |
According to below, Go supports only two newer versions, so we can reduce the support versions, I think.
|
I agree with stopping code mirroring since it also is a maintenance cost to developers. I'm not familiar with the migration of Go Modules, what about Major branch approach? This current repository takes Major subdirectory now. Just for reference, it seems that https://github.com/caarlos0/env takes Major branch approach. |
There's currently no need to drop support for two additional versions, as there are no breaking changes like in #367 which require us to remove them. |
Discussion moved to #503 |
Implementing fuzzing got things moving and #466 surfaced some problems regarding the v3 directory:
Since #367, we can't support older versions anyways as they're missing the necessary struct fields, meaning all versions used afterwards have Go modules integrated, which in turn means that there should be little to no breaking changes when dropping/stop mirroring the v3 directory. But, this would mean that programs >Go 1.14 which have the v3 directory imported need to be updated.
I want to start an open discussion about stopping mirroring the code. Any opinions are welcome.
The text was updated successfully, but these errors were encountered: