Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error unmarshalling ApplyEdit response #38

Open
dan1994 opened this issue Sep 9, 2022 · 0 comments
Open

Error unmarshalling ApplyEdit response #38

dan1994 opened this issue Sep 9, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@dan1994
Copy link

dan1994 commented Sep 9, 2022

When testing against vscode, using client.ApplyEdit fails when unmarshalling the response. It looks like the response structure should be struct{Applied bool `json:"applied"`}, but it's unmarshalled directly into the boolean result. I was able to confirm this by creating my own client that implements a patched ApplyEdit.
It's probably worth taking into account the other optional fields declared by the spec[1].

[1] https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#applyWorkspaceEditResult

@zchee zchee added the bug Something isn't working label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants