-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerical enum fails #28
Comments
Hi @betim thanks for reporting the issue with generating enum files. Regarding feature request, could you describe you use case for overwriting files. Why do you have to keep other code in generator folder? |
At first I wanted to have a controller directory inside On the other hand, it would be great if there is a mode where you generate a directory for a table, say
in this case it would be great to have the I'm not sure if there are patterns like this, but I think this kind of separation would be quite clean. |
It is usually a bad practice to mix generated and custom files in the same directory. In the future there might be a feature for a user to specify folder structure, but it is not a priority now. Even then, unless there are valid use cases, generator will clean up directory before generating the files, to avoid some dangerous edge cases. For instance if the user deletes table from the database, and generator works in overwrite mode, sql builder and model files for that table will remain. |
Crash on generating enum SQL Builder files when database enum contains numeric values is fixed with release the v2.2.0. |
Hi,
I just noticed that when an enum has a numerical numerator, the thing crashes quite ambiguously:
Also a feature request: can you add a flag say
-overwrite
which will only overwrite files and keep other things intact, for now I've commented:Cheers
The text was updated successfully, but these errors were encountered: