Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ipv4 as table name in mysql #3534

Closed
kiyonlin opened this issue Sep 26, 2020 · 2 comments
Closed

use ipv4 as table name in mysql #3534

kiyonlin opened this issue Sep 26, 2020 · 2 comments
Assignees
Labels

Comments

@kiyonlin
Copy link

kiyonlin commented Sep 26, 2020

GORM Playground Link

go-gorm/playground#155

Description

We now have such a requirement to use ipv4 as the table name, and each table stores this ipv4's information.

Use such SQL statements when querying.

select * from `ip_db`.`1.1.1.1` limit 0,1000

When quoting the table name, the current processing logic is to separat it by dots, and each substring is wrapped with a pair of ``.

1.1.1.1     => `1`.`1`.`1`.`1`
`1.1.1.1`   => ``1`.`1`.`1`.`1``

Can we improve the quote processing logic so that the table names that have been used ``are not processed again?

1.1.1.1     => `1`.`1`.`1`.`1`
`1.1.1.1`   => `1.1.1.1`
@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label Sep 26, 2020
@github-actions
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 2 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@jinzhu
Copy link
Member

jinzhu commented Sep 27, 2020

Hi,

I would suggest write a wrapper to the existing driver, and rewrite the QuoteTo methods to do the job. GORM itself won't make the support, thank you.

@jinzhu jinzhu closed this as completed Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants