-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cancel button in the page of project edit not work #23655
Fix cancel button in the page of project edit not work #23655
Conversation
It's a regression of my suggestion in #23337 The proper fix should be : use |
…ong/gitea into bugfix/project_cance_editl_btn
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23655 +/- ##
==========================================
+ Coverage 47.14% 47.16% +0.02%
==========================================
Files 1149 1154 +5
Lines 151446 152382 +936
==========================================
+ Hits 71397 71873 +476
- Misses 71611 72034 +423
- Partials 8438 8475 +37
... and 41 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I was unable to create a backport for 1.19, please send one manually. 🍵 |
Before, in project edit page, the cancel button is not work. https://user-images.githubusercontent.com/33891828/227182731-6478e29f-0e52-48c4-beb0-6a7d1dda6a1d.mov 1. The wrong classname `cancel` was added to the `<a>` tag. That classname caused the default click event of `<a>` tag to be cancelled. Because we have the following settings in the global. So I remove the classname `cancel`. https://github.com/go-gitea/gitea/blob/9be90a58754061171bbd5025d85d2b891364efd3/web_src/js/features/common-global.js#L325-L327 2. Another change is that page will redirect to the previous page. https://user-images.githubusercontent.com/33891828/227187326-c653c6d6-9715-440f-a732-ba0a6f012c81.mov # Conflicts: # templates/projects/new.tmpl # templates/repo/projects/new.tmpl # web_src/js/features/common-global.js
Backport #23655 Before, in project edit page, the cancel button is not work. https://user-images.githubusercontent.com/33891828/227182731-6478e29f-0e52-48c4-beb0-6a7d1dda6a1d.mov 1. The wrong classname `cancel` was added to the `<a>` tag. That classname caused the default click event of `<a>` tag to be cancelled. Because we have the following settings in the global. So I remove the classname `cancel`. https://github.com/go-gitea/gitea/blob/9be90a58754061171bbd5025d85d2b891364efd3/web_src/js/features/common-global.js#L325-L327 2. Another change is that page will redirect to the previous page. https://user-images.githubusercontent.com/33891828/227187326-c653c6d6-9715-440f-a732-ba0a6f012c81.mov
Before, in project edit page, the cancel button is not work.
Screen.Recording.2023-03-23.at.17.55.08.mov
cancel
was added to the<a>
tag. That classname caused the default click event of<a>
tag to be cancelled. Because we have the following settings in the global. So I remove the classnamecancel
.gitea/web_src/js/features/common-global.js
Lines 325 to 327 in 9be90a5
Screen.Recording.2023-03-23.at.19.15.23.mov