Fix inconsistent PR comment counts #18260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't want reviews to count towards comments, as this needs changes in other components as well (eg repo stats cron job, etc).
6543
approved these changes
Jan 13, 2022
GiteaBot
added
the
lgtm/need 1
|
add a doctor task to fix wrong records? |
|
@6543 |
lunny
approved these changes
Jan 13, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 14, 2022
* 'main' of https://github.com/go-gitea/gitea: [skip ci] Updated translations via Crowdin Improve the comment for 2FA filter in admin panel (go-gitea#18017) fix regression from go-gitea#16075 (go-gitea#18260) Prevent underline hover on cards (go-gitea#18259) Fix release link broken (go-gitea#18252) migrations: a deadline at January 1st, 1970 is valid (go-gitea#18237)
Merged
zeripath
pushed a commit
that referenced
this pull request
Jan 14, 2022
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (#18260) (#18261) * Fix release link broken (#18252) (#18253) * Fix update user from site administration page bug (#18250) (#18251) * Set HeadCommit when creating tags (#18116) (#18173) * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152) * Fix purple color in suggested label colors (#18241) (#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206)
zeripath
pushed a commit
to zeripath/gitea
that referenced
this pull request
Jan 14, 2022
[1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261) * Fix release link broken (go-gitea#18252) (go-gitea#18253) * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251) * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173) * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152) * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206)
techknowlogick
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Changelog for 1.15.10 (#18274) [1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (#18260) (#18261) * Fix release link broken (#18252) (#18253) * Fix update user from site administration page bug (#18250) (#18251) * Set HeadCommit when creating tags (#18116) (#18173) * Use correct translation key for error messages due to max repo limits (#18135 & #18153) (#18152) * Fix purple color in suggested label colors (#18241) (#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (#18198) (#18206) * update docs/config.yaml Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Richard Mahn <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
we don't want reviews to count towards comments, as this needs changes in other components as well (eg repo stats cron job, etc). Co-authored-by: 6543 <[email protected]>
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
* Changelog for 1.15.10 (go-gitea#18274) [1.15.10](https://github.com/go-gitea/gitea/releases/tag/v1.15.10) - 2022-01-14 * BUGFIXES * Fix inconsistent PR comment counts (go-gitea#18260) (go-gitea#18261) * Fix release link broken (go-gitea#18252) (go-gitea#18253) * Fix update user from site administration page bug (go-gitea#18250) (go-gitea#18251) * Set HeadCommit when creating tags (go-gitea#18116) (go-gitea#18173) * Use correct translation key for error messages due to max repo limits (go-gitea#18135 & go-gitea#18153) (go-gitea#18152) * Fix purple color in suggested label colors (go-gitea#18241) (go-gitea#18242) * SECURITY * Bump mermaid from 8.10.1 to 8.13.8 (go-gitea#18198) (go-gitea#18206) * update docs/config.yaml Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Richard Mahn <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the comment count on PRs consistent with repostats cronjob behaviour again: ie. don't try to count review comments towards issue comment count (fixing a regression from #16075).
This is also a bugfix for API clients, that rely on that count to fetch issue comments (but that API does not include review comments, resulting in bad client state).
fixes #16901
In a later PR we can aim at counting PR-reviews & code comments towards the the PR comment count similar to github.