Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Accessibility for Dropdown (#16576) #16617

Merged
merged 1 commit into from
Aug 4, 2021

Commits on Aug 4, 2021

  1. Restore go-gitea#10096/go-gitea#8638 and re-fix go-gitea#15172 (go-gi…

    …tea#16576)
    
    Backport go-gitea#16576
    
    This PR restores the vendored and patched dropdow from go-gitea#8638. It
    however, it partially abandons the call to `click()` using instead the
    default dropdown click calls instead. This prevents the issue of the
    dropdown grabbing focus permanently however, this may have negative
    effects on the effect of focus on the dropdowns.
    
    Of note, the behaviour of the template selector dropdown on the repo
    creation page is slightly odd - I don't believe that this odd behaviour
    is caused by this PR but rather by the feed source for this. I suspect
    that the dropdown should be adding a delete button to its selection.
    
    Fix go-gitea#15172
    References: go-gitea#7057
    
    Signed-off-by: Andrew Thornton <[email protected]>
    zeripath committed Aug 4, 2021
    Configuration menu
    Copy the full SHA
    fc6118e View commit details
    Browse the repository at this point in the history