Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Flexible redirect_uri of OAuth2 #9514

Open
meteorlxy opened this issue Dec 27, 2019 · 2 comments
Open

[Feature Request] Flexible redirect_uri of OAuth2 #9514

meteorlxy opened this issue Dec 27, 2019 · 2 comments
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@meteorlxy
Copy link

  • Gitea version (or commit ref): d151503
  • Git version:
  • Operating system:
  • Database (use [x]):
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

func (app *OAuth2Application) ContainsRedirectURI(redirectURI string) bool {
return com.IsSliceContainsStr(app.RedirectURIs, redirectURI)
}

Currently, gitea test redirect_uri via com.IsSliceContainsStr, which requires redirect_uri to be exact the same (ignoring case), which is not flexible.

Hope we can support all / some of those features:

  • Trim ending slash (e.g. currently http://domain.com/ is not valid for http://domain.com)
  • Wildcard (e.g. http://domain.com/*)
  • ...
@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 27, 2019
@meteorlxy
Copy link
Author

@jonasfranz

@mahdiG
Copy link

mahdiG commented Dec 12, 2022

I need to pass query parameters in my redirect uri but it doesn't work 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants