Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement well known OpenID Configuration #8775

Closed
tommyknows opened this issue Nov 1, 2019 · 16 comments
Closed

Implement well known OpenID Configuration #8775

tommyknows opened this issue Nov 1, 2019 · 16 comments
Assignees
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone

Comments

@tommyknows
Copy link

tommyknows commented Nov 1, 2019

Description

The PR #5378 initially implemented the OAuth2 provider. I love the idea to have gitea as my SSO provider :-)
However, it seems like the .well-known/... endpoints are missing. This is also stated in the PR, "will be implemented in another PR".
I'm trying to get ArgoCD to work (see this), and it seems like it tries to connect to https://<server>/ .well-known/openid-configuration, which does not exist and returns a 401.

I guess this goes into the same direction as #8534.

Would be cool if gitea had support for that as well!

Edit: More info on the endpoint can be found here

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Nov 2, 2019
@lunny
Copy link
Member

lunny commented Nov 2, 2019

I think that's the part of OpenID provider standard but gitea doesn't implement.

@tommyknows
Copy link
Author

Yes. Interestingly, there is a reference to this endpoint here:

auths.tip.openid_connect = Use the OpenID Connect Discovery URL (<server>/.well-known/openid-configuration) to specify the endpoints

Sadly I don't think it is relevant at all 🙂

@lafriks
Copy link
Member

lafriks commented Nov 5, 2019

I have started implementing it

@josipradic
Copy link

@lafriks Glad to see someone is working on it! Any news when we can except this feature to be merged? Thanks a lot!

@lafriks
Copy link
Member

lafriks commented Jan 8, 2020

I'm planning to finish it for 1.12

@techknowlogick
Copy link
Member

How would this work when Gitea is running in a subpath (ie, example.com/gitea/)? I'm thinking we could probably put in docs that it isn't supported for for subpath installations (because .well-known has to be served from root path)

@lafriks
Copy link
Member

lafriks commented Jan 8, 2020

@techknowlogick that is not true, it is supported to have it also in subpath

@mnavarrocarter
Copy link

Hi there. I've been researching about OpenID Connect because I'm really interested in centralize auth credentials in gitea for our dev team.

I still don't fully undertand OIDC but correct me if I'm wrong. Would it be possible to implement my own ./well-known/openid-configuration if I write it and serve it statically from my http proxy before the request hits Gitea?

As far as I understand, that file is some sort of mapper of the available oauth endpoints and grant types, right?

@droplet-js
Copy link

any news update?

@pat-s
Copy link
Member

pat-s commented Oct 18, 2020

AFAIC this works already?

@sikmir
Copy link

sikmir commented Oct 18, 2020

AFAIC this works already?

No, still missing userinfo endpoint.

@droplet-js
Copy link

any news update?

@artizirk
Copy link

@techknowlogick
Copy link
Member

@artizirk I've just sent a PR for well-known: #15355

@artizirk
Copy link

artizirk commented May 6, 2021

Looks like well-known and userinfo are merged. this can be closed then?

@lunny
Copy link
Member

lunny commented May 7, 2021

Closed by #15721 and #15355

@lunny lunny closed this as completed May 7, 2021
@6543 6543 added this to the 1.15.0 milestone May 7, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests