Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No link to external issue tracker in commit message #7121

Closed
2 of 7 tasks
joestr opened this issue Jun 4, 2019 · 8 comments
Closed
2 of 7 tasks

No link to external issue tracker in commit message #7121

joestr opened this issue Jun 4, 2019 · 8 comments

Comments

@joestr
Copy link

joestr commented Jun 4, 2019

  • Gitea version (or commit ref): 1.9.0+dev-319-g160e7edd0
  • Git version: 2.7.4
  • Operating system: Ubuntu 16.04.06
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
  • Log gist:

Description

I linked to an external issue tracker, but if I mention e.g. 'Fixing #2' in a commit message, there is no URL to click.

Screenshots


@joestr
Copy link
Author

joestr commented Jun 4, 2019

Ah, the link only appears if I click on the commit itself.

But wouldn't it be more convenient if the links would appear in the commit history and repository overview too? (like in GitHub)

@mrsdizzie
Copy link
Member

mrsdizzie commented Jun 4, 2019

This was changed in the past due to issues like #6809

And as noted, the links are still present for the commit itself. So was a slight trade off for consistency given the differences in Gitea design and implementation of the links

@joestr
Copy link
Author

joestr commented Jun 4, 2019

Would it be possible just to render the '#2' as a valid link? Since the referenced Issue complained about the whole commit message being a link?

@mrsdizzie
Copy link
Member

Not without several other changes -- its the same code that sees #2 and #2222222222, or http://reallylongurl.com or 45f588e85dbd3004334718dc9fbbb27675814ee0 as things to link so while you're particular example wouldn't take up the entire title another would.

@mrsdizzie
Copy link
Member

Personally I wouldn't mind if they appeared in the commit view since those aren't already links to something else, but I do think they are broken in the repository view and can create a bad experience where it is possible to completely hide/break the link to the commit itself.

They are just disabled for commit view for consistency with repository view since then the issue would just be "its enabled in one similar list view but not the other".

@joestr
Copy link
Author

joestr commented Jun 4, 2019

Hm, ok I will accept it then. Thanks for answering my question!

@stale
Copy link

stale bot commented Aug 3, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Aug 3, 2019
@stale
Copy link

stale bot commented Aug 17, 2019

This issue has been automatically closed because of inactivity. You can re-open it if needed.

@stale stale bot closed this as completed Aug 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants