Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline avatars of code comments on pull request page doesn't not align vertically. #30915

Open
lunny opened this issue May 9, 2024 · 3 comments
Open

Timeline avatars of code comments on pull request page doesn't not align vertically. #30915

lunny opened this issue May 9, 2024 · 3 comments
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI

Comments

@lunny
Copy link
Member

lunny commented May 9, 2024

image

https://gitea.com/gitea/helm-chart/pulls/596
@lunny lunny added topic/ui Change the appearance of the Gitea UI issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change labels May 9, 2024
@yp05327
Copy link
Contributor

yp05327 commented May 24, 2024

@wxiaoguang
I tried to revert #29935, then it works well.
So I think it is caused by #29935. Maybe we should not add timeline-avatar-offset class in this case

@wxiaoguang
Copy link
Contributor

Before 29935, see #29934, I do not think 29935 is directly related. 29935 is written to fix the bug described by #29934

Maybe it needs more code to check different cases.

image

@yp05327
Copy link
Contributor

yp05327 commented Sep 12, 2024 •
edited
Loading

I'm confusing which is right.
And why reviews should have timeline-avatar-offset.
It seems that it comes from https://github.com/go-gitea/gitea/pull/24526/files#r1188069927

It is used for this case?
image

In github:
image

Maybe adjust the direction of "speech bubble" is much easier than adding these complex conditions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue/regression Indicates a previously functioning feature or behavior that has broken or regressed after a change topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lunny @wxiaoguang @yp05327