Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logger not output messages when logging fatal #2958

Closed
free1139 opened this issue Nov 22, 2017 · 7 comments
Closed

The logger not output messages when logging fatal #2958

free1139 opened this issue Nov 22, 2017 · 7 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug

Comments

@free1139
Copy link

I have been trying to install gitea (master and v1.3) today, but when i finish install it from browser, the go program was exited without any error messages, when i run "./gitea web" again, it can not be restarted.

I have debugged it, and i found "code.gitea.io/gitea/modules/log".Fatal was using go channel to output messages, maybe os.Exit was called before outputting messages .

My server system information:
Linux iZ23mbdnjl9Z 3.2.0-4-amd64 #1 SMP Debian 3.2.78-1 x86_64 GNU/Linux
CPU: 1 core

Maybe need to fix this code:
image

Official output:
image

Expect output:
image

@lunny
Copy link
Member

lunny commented Nov 22, 2017

Which file do you find the os.Exit?

@free1139
Copy link
Author

code.gitea.io/gitea/modules/log/log.go

@lafriks
Copy link
Member

lafriks commented Nov 24, 2017

You need to set rights for git user rights to have write access to that directory

@free1139
Copy link
Author

Yes, it have no rights, the problem is that the official logger not output error message in this case, it's hard to installing without source code debugging, maybe it's not appropriate for newcomers.

@stale
Copy link

stale bot commented Feb 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

@stale stale bot added the issue/stale label Feb 10, 2019
@lunny lunny added the type/bug label Feb 11, 2019
@stale stale bot removed the issue/stale label Feb 11, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Feb 11, 2019
@lunny
Copy link
Member

lunny commented Feb 11, 2019

This should be a bug of log module. The log haven't write to console or file and the application exited.

@wxiaoguang
Copy link
Contributor

It should have been fixed by

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented type/bug
Projects
None yet
Development

No branches or pull requests

4 participants