Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate an OAuth2 consumer #26

Closed
tboerger opened this issue Nov 3, 2016 · 12 comments
Closed

Integrate an OAuth2 consumer #26

tboerger opened this issue Nov 3, 2016 · 12 comments
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Milestone

Comments

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

To keep the barrier of Gitea as small as possible we should integrate an OAuth2 consumer. That way new users can register with just a few clicks and can reuse there already elsewhere existing accounts. A good library for that can be https://github.com/markbates/goth.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@tboerger tboerger added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@tboerger tboerger added this to the 1.1.0 milestone Nov 3, 2016
@tboerger tboerger added type/feature Completely new functionality. Can only be merged if feature freeze is not active. and removed type/enhancement An improvement of existing functionality labels Nov 3, 2016
@bkcsoft
Copy link
Member

bkcsoft commented Jan 9, 2017

oauth for searchabilty

( GitHub fix your search-engine FFS 😒 )

@willemvd
Copy link
Contributor

willemvd commented Jan 9, 2017

This would mean some area in the admin panel/app.ini to setup OAuth2 client_id, client_secret and a provider based on the goth provider list

Do we want to support non-existing goth providers (like MS ADFS/Office365) and let users enter a custom token & authorize url which we then can use to either create a new goth provider (not sure how) or use the golang.org/x/oauth2 package?

@tboerger
Copy link
Member Author

I think on the first step we will support the goth providers, but on another step we should also try to support more providers.

@lunny
Copy link
Member

lunny commented Feb 22, 2017

So this has been resolved by #679 ?

@willemvd
Copy link
Contributor

it will be broken in to multiple PR's, first part is in #679 , but I don't think we need this as reference for the other PR's

@lunny
Copy link
Member

lunny commented Feb 22, 2017

So let's close this.

@Lichtjaeger
Copy link

Nice work. But I would like to use Gitea on our intranet with our own OAuth2 provider (self-made with NodeJS).

I hope, this is planned for the next releases.

@laf0rge
Copy link

laf0rge commented Jun 4, 2019

I also have several use cases (even on the public inthernet) where I'd want to be able to provide my own OAuth provider. Particularly privacy-sensitive users would not typically like to share too much data with the large Oauth "providers". So I think it's quite desirable for every entity/organization to run their own OAuth provider and not just rely on the big OAuth providers.

@lunny
Copy link
Member

lunny commented Jun 5, 2019

I think you mean a customize OAuth2 config UI? @Lichtjaeger @laforge Maybe we could create another issue to discuss that.

@bryanpedini
Copy link

I think you mean a customize OAuth2 config UI? @Lichtjaeger @laforge Maybe we could create another issue to discuss that.

Just crossing around open / solved issues of Gitea to better understand the underlying golang structure...
Immediately noticed you menti@ned the wrong user, @lunny, that 'o' was a zero..

@lunny
Copy link
Member

lunny commented Jun 16, 2019

@bryanpedini You are right. Sorry, @laf0rge

@Lichtjaeger
Copy link

@lunny @laf0rge
This feature request has long been fulfilled. I'm using Gitea with our own auth server successfully for over a year now.
grafik
grafik

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

No branches or pull requests

7 participants