Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reviewers to be added when creating a Pull Request, the same way as assignees can be added #13905

Open
2 of 6 tasks
ashleykleynhans opened this issue Dec 8, 2020 · 6 comments
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@ashleykleynhans
Copy link

Description

The gitea API allows assignee/assignees to be added when creating a Pull Request using the API.
It would be really useful if the API could also allow reviewer/reviewers to be added in the same way.

Screenshots

N/A

@a1012112796 a1012112796 added modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first. and removed type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Dec 9, 2020
@jpraet
Copy link
Member

jpraet commented Dec 23, 2020

This is currently not possible through the UI either at pull request creation time.
The reviewers can only be added after the PR has been created:

image

@Sodj
Copy link

Sodj commented Feb 16, 2023

This would be useful

@muhtarmamatov
Copy link

Is there any progress on this issue

@delvh
Copy link
Member

delvh commented Dec 8, 2023

Technically yes, have a look at CODEOWNERS which ships with 1.21.

@muhtarmamatov
Copy link

Thank you @delvh,
Already tested your suggestion if configure with regex reviewers successfully assigned. Problem when assign reviwers to specific folder.

Below example I have tried:

     /docs/  @org-1/Team2
     /frontend/src/   @org-1/Team1
    /folder/sub-folder/  @user1

 
 All three folders(docs, frontend, folder) are located at the root of repository.

@jpraet
Copy link
Member

jpraet commented Dec 29, 2023

CODEOWNERS seems related, but not exactly what was requested in this issue.

But there is a PR that resolves the requested feature: #26596

@lunny lunny added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
modifies/api This PR adds API routes or modifies them type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

7 participants