From a51d2114c7c0472cf20459dd8916bf48d529ae83 Mon Sep 17 00:00:00 2001 From: Kyle D Date: Sat, 5 Feb 2022 11:31:57 -0700 Subject: [PATCH] quote MAKE to prevent path expansion with space error (#18622) Pretty minor change to prevent error when `$(MAKE)` path is expanded with a space in the path. ```bash $ TAGS="bindata sqlite sqlite_unlock_notify" make build /usr/bin/sh: -c: line 0: syntax error near unexpected token `(' /usr/bin/sh: -c: line 0: `C:/Program Files (x86)/GnuWin32/bin/make -v | head -n 1' ``` I believe Program Files (x86) is the default path for GNU make on windows --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3c4a991fd2da1..88e08c1e70641 100644 --- a/Makefile +++ b/Makefile @@ -60,7 +60,7 @@ endif EXTRA_GOFLAGS ?= -MAKE_VERSION := $(shell $(MAKE) -v | head -n 1) +MAKE_VERSION := $(shell "$(MAKE)" -v | head -n 1) MAKE_EVIDENCE_DIR := .make_evidence ifeq ($(RACE_ENABLED),true)