Skip to content

Commit

Permalink
Disable sending email after push a commit to a closed PR (#23462)
Browse files Browse the repository at this point in the history
Close #23440
Cause by #23189
In #23189, we should insert a comment record into db when pushing a
commit to the PR, even if the PR is closed.
But should skip sending any notification in this case.

---------

Co-authored-by: Lunny Xiao <[email protected]>
  • Loading branch information
sillyguodong and lunny authored Mar 15, 2023
1 parent e7e6250 commit 0d7cf7b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion services/pull/pull.go
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,12 @@ func AddTestPullRequestTask(doer *user_model.User, repoID int64, branch string,
continue
}

// If the PR is closed, someone still push some commits to the PR,
// 1. We will insert comments of commits, but hidden until the PR is reopened.
// 2. We won't send any notification.
AddToTaskQueue(pr)
comment, err := CreatePushPullComment(ctx, doer, pr, oldCommitID, newCommitID)
if err == nil && comment != nil {
if err == nil && comment != nil && !pr.Issue.IsClosed {
notification.NotifyPullRequestPushCommits(ctx, doer, pr, comment)
}
}
Expand Down

0 comments on commit 0d7cf7b

Please sign in to comment.