From 90a1571f88ef7cfe9218938e7184d299edc1a7be Mon Sep 17 00:00:00 2001 From: Alessandro Arzilli Date: Fri, 20 Oct 2023 19:05:58 +0200 Subject: [PATCH] CI: update staticcheck version (#3533) Update staticcheck version and re-enable TestStaticcheck on Go 1.22. --- _scripts/test_linux.sh | 2 +- cmd/dlv/dlv_test.go | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/_scripts/test_linux.sh b/_scripts/test_linux.sh index 523456c6ef..a0db51eef6 100755 --- a/_scripts/test_linux.sh +++ b/_scripts/test_linux.sh @@ -50,7 +50,7 @@ export GOPATH export PATH=$PATH:$GOROOT/bin:$GOPATH/bin go version if [ "$arch" != "ppc64le" ]; then - go install honnef.co/go/tools/cmd/staticcheck@2023.1 || true + go install honnef.co/go/tools/cmd/staticcheck@2023.1.6 || true fi uname -a diff --git a/cmd/dlv/dlv_test.go b/cmd/dlv/dlv_test.go index eb5169ec3b..32cc2d51c3 100644 --- a/cmd/dlv/dlv_test.go +++ b/cmd/dlv/dlv_test.go @@ -1310,9 +1310,6 @@ func TestStaticcheck(t *testing.T) { if err != nil { t.Skip("staticcheck not installed") } - if goversion.VersionAfterOrEqual(runtime.Version(), 1, 22) { - t.Skip("broken with staticcheck@2023.1") - } // default checks minus SA1019 which complains about deprecated identifiers, which change between versions of Go. args := []string{"-tests=false", "-checks=all,-SA1019,-ST1000,-ST1003,-ST1016,-S1021,-ST1023", "github.com/go-delve/delve/..."} // * SA1019 is disabled because new deprecations get added on every version