Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for provider: ManageEngine CloudDNS #1933

Closed
5 tasks done
dgarner-cg opened this issue Jun 10, 2023 · 18 comments · Fixed by #2365
Closed
5 tasks done

Support for provider: ManageEngine CloudDNS #1933

dgarner-cg opened this issue Jun 10, 2023 · 18 comments · Fixed by #2365

Comments

@dgarner-cg
Copy link

dgarner-cg commented Jun 10, 2023

Welcome

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, the DNS provider exposes a public API.
  • Yes, I know that the lego maintainers don't have an account in all DNS providers in the world.
  • Yes, I'm able to create a pull request and be able to maintain the implementation.
  • Yes, I'm able to test an implementation if someone creates a pull request to add the support of this DNS provider.

How do you use lego?

Binary

Link to the DNS provider

https://clouddns.manageengine.com/

Link to the API documentation

https://pitstop.manageengine.com/portal/en/kb/articles/manageengine-clouddns-rest-api-documentation#GET_All_9

Additional Notes

Pu-leeeeees. :D

@ldez ldez changed the title Support for provider: Support for provider: ManageEngine CloudDNS Jun 10, 2023
@ldez
Copy link
Member

ldez commented Jun 10, 2023

Hello,

you have check the following box:

- [X] Yes, I know that the lego maintainers don't have an account in all DNS providers in the world.
- [X] Yes, I'm able to create a pull request and be able to maintain the implementation.
- [X] Yes, I'm able to test an implementation if someone creates a pull request to add the support of this DNS provider.

This means that you will create a PR, do you need help?

@ldez
Copy link
Member

ldez commented Jul 12, 2023

@dgarner-cg any news?

@ldez
Copy link
Member

ldez commented Sep 22, 2024

@dgarner-cg do you need help?

@dgarner-cg
Copy link
Author

@ldez Yes, I created a plugin for Manage Engine, unfortunately my plugin was incredibly more involved and requires considerably more work than a simple one pager.

I am not sure why, but after working with the Product Owner at Manage Engine, who was very generous with his time, this was the best we could do.

If you have any feedback or are able to help, I'd love assistance. I believe one of the last updates broke our solution and all of my certificates are now expired as my data center was offline for a few months while initiating and pending a personal matter.

I can provide our files and correspondence if that helps as to why we did it the way we did, or simply the API documentation if you are unable to find it.

But you'd be a godsend for providing assistance. :p

@ldez
Copy link
Member

ldez commented Nov 29, 2024

@dgarner-cg I created PR #2365 based on the API documentation, can you try it?

@ldez ldez added the state/need-user-tests Need users to test functionality label Nov 29, 2024
@dgarner-cg
Copy link
Author

dgarner-cg commented Nov 29, 2024

@dgarner-cg I created PR #2365 based on the API documentation, can you try it?

@ldez Yes sir, it may be around 1h before I can sit down uninterrupted and try it, go is not installed on pfsense by default and is discouraged to install non-pfsense repo packages on firewall, but I will give a shot anyway..

Default way to install is simply use Acme plugin so they can be managed in GUI.

@ldez
Copy link
Member

ldez commented Nov 29, 2024

You can try it locally, you don't need to install it on pfsense.

@dgarner-cg
Copy link
Author

dgarner-cg commented Nov 29, 2024 via email

@dgarner-cg
Copy link
Author

dgarner-cg commented Nov 29, 2024 via email

@dgarner-cg
Copy link
Author

dgarner-cg commented Nov 30, 2024 via email

@ldez
Copy link
Member

ldez commented Nov 30, 2024

It feels like you are not using the right commands.

This command go build -trimpath -ldflags '-X "main.version="' -o /home/ssmith/lego/ cannot work and go build too.

You should follow the instructions from the section "How to test this PR?" inside the issue: #2365 (comment)

$ git clone https://github.com/ldez/lego.git
Cloning into 'lego'...
remote: Enumerating objects: 24629, done.
remote: Counting objects: 100% (1272/1272), done.
remote: Compressing objects: 100% (441/441), done.
remote: Total 24629 (delta 927), reused 1083 (delta 819), pack-reused 23357 (from 1)
Receiving objects: 100% (24629/24629), 14.26 MiB | 100.00 KiB/s, done.
Resolving deltas: 100% (14606/14606), done.
$ cd lego
$ git checkout feat/manageengine
branch 'feat/manageengine' set up to track 'origin/feat/manageengine'.
Switched to a new branch 'feat/manageengine'
$ make build       
BIN_OUTPUT: dist/lego
rm -rf dist/ builds/ cover.out
Version: e07c5b27f706d874d56eded62b3c4f782d99df16
go build -trimpath -ldflags '-X "main.version=e07c5b27f706d874d56eded62b3c4f782d99df16"' -o  dist/lego ./cmd/lego/
$

@dgarner-cg
Copy link
Author

dgarner-cg commented Dec 1, 2024 via email

@ldez
Copy link
Member

ldez commented Dec 1, 2024

can you answer through the GitHub UI (not email) with the full logs?

@ldez
Copy link
Member

ldez commented Dec 2, 2024

any news?

@dgarner-cg
Copy link
Author

dgarner-cg commented Dec 2, 2024 via email

@ldez
Copy link
Member

ldez commented Dec 2, 2024

can you use single quotes instead of double quotes?
and single quotes around the wildcard domain?

MANAGEENGINE_CLIENT_ID='xxx' \
MANAGEENGINE_CLIENT_SECRET='yyy' \
./dist/lego -m [email protected] --dns manageengine -d '*.example.com' -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

FYI No match. is not an error from lego but from your shell.

@ldez
Copy link
Member

ldez commented Dec 7, 2024

@dgarner-cg any news?

@dgarner-cg
Copy link
Author

dgarner-cg commented Dec 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants