Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Test release v0.8 #376

Closed
anxolin opened this issue Mar 31, 2021 · 3 comments
Closed

Test release v0.8 #376

anxolin opened this issue Mar 31, 2021 · 3 comments
Assignees
Labels
app:CowSwap CowSwap app

Comments

@anxolin
Copy link
Contributor

anxolin commented Mar 31, 2021

We currently have a draft of v0.8.0 release. It still don't work because uses the newest contracts. @alfetopito and @fleupold will be coordinating the upgrade tomorrow.

After we do the upgrade, we can do some basic smoke tests, to verify the happy paths.
#375

We are aware the release is under documented. We will try to provide better context tomorrow.

@anxolin anxolin added the app:CowSwap CowSwap app label Mar 31, 2021
@W3stside
Copy link
Contributor

W3stside commented Apr 5, 2021

@MareenG Leaving some more information on testing below:

1. consider fee

2. tooltip info on sell/buy inputs

  • tooltip should show:

    • Sell swap: fee tooltip shown in "To" input field, and numerically represented in receive token: Screenshot from 2021-04-05 14-23-22
    • Buy swap: fee tooltip shown in "From" input field, represented numerically in sell token:
      Screenshot from 2021-04-05 14-25-11

3. swap dropdown (when buy/sell and amounts selected): Screenshot from 2021-04-05 14-25-42

4. modals after selecting "Swap": Screenshot from 2021-04-05 14-33-06

5. Metamask/wallet confirmation modal w/order data

  • infomation is correctly represented in atoms (token decimals multiplied by amounts) - e.g OWL @ 18 decimals, buying 20, shown as 20000000000000000000

  • When order type = buy - make sure:

Screenshot from 2021-04-05 15-09-52
- sellAmount: shown as slippage adjusted amount MINUS the feeAmount in atoms (see step 6 for slippage calculation). sellAmount + feeAmount divided by it's decimals (amountInAtoms / 10**decimals) should equal the exact amount input by you in the "From" input field
- buyAmount: should be the exact amount you typed in, but represented in atoms

  • When order type = sell - make sure:

Screenshot from 2021-04-05 15-11-36

  • sellAmount: feeAmount + sellAmount in signing modal should be the exact amount you typed in, but represented in atoms
  • buyAmount: should be the buyAmount adjusted for slippage. The amount shown in the Minimum received section in the dropdown calculated by: buyAmount shown in "To" field * (1 + slippage):
    Screenshot from 2021-04-05 19-07-36

6. toast notifications after submitting a swap:

  • submission message should use SLIPPAGE amounts (original sell/buy amount * (1 + slippage))

    • [sell swap] e.g: selling exactly X WETH = 10[expected OWL buy] * (1 - 0.005[0.5% slippage]) = Swap X WETH for at least 9.95 OWL
      Screenshot from 2021-04-05 15-11-43

    • [buy swap] e.g: buying exactly X OWL = 10[expected WETH sell] * (1 + 0.005[0.5% slippage]) = Swap at most 10.05 WETH for X OWL:
      Screenshot from 2021-04-05 15-10-00

  • swap confirmation message should use actual traded amounts which can be verified on Explorer

@W3stside
Copy link
Contributor

W3stside commented Apr 8, 2021

Edited comment as @MareenG correctly pointed out I was wrong about what to see in sellAmount when selling

@W3stside
Copy link
Contributor

W3stside commented Apr 9, 2021

@MareenG the calculations for buy/sell with slippage and fee are not in this version, thanks for pointing that out. We will make a release for this on Monday - v0.9 likely. For now please skip instructions for correct numbers in step 5
Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:CowSwap CowSwap app
Projects
None yet
Development

No branches or pull requests

3 participants