Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not switch input methods with fcitx in terminator #667

Closed
mjw10086 opened this issue Nov 2, 2022 · 11 comments
Closed

Can not switch input methods with fcitx in terminator #667

mjw10086 opened this issue Nov 2, 2022 · 11 comments
Labels
bug Something isn't working question Further information is requested regression used to work, now doesn't

Comments

@mjw10086
Copy link

mjw10086 commented Nov 2, 2022

Package: terminator
Version: 2.1.2-1
system: Linux kali 5.19.0-kali2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 5.19.11-1kali2 (2022-10-10) x86_64 GNU/Linux

Gnome 43.0

Composed key such as ctrl + shift + o works, but shift or ctrl + space can not switch input method in 2.1.2-1, but 2.1.0-2 is OK.

@mattrose mattrose added the question Further information is requested label Nov 3, 2022
@mattrose
Copy link
Member

mattrose commented Nov 3, 2022

Can you be a little more clear?

@mjw10086
Copy link
Author

mjw10086 commented Nov 3, 2022

@mattrose my situation is that I can't input Chinese in terminator with fcitx

those code may lead fcitx not work in terminator, after I comment those, It works. I don't know how to fix that, it seems that is relative with another issue?

# Deleting env variable fixes double char problem when broadcasting (#78)
# Only delete if it exists, or exception occurs
if os.environ.get("GTK_IM_MODULE") is not None:
    del os.environ["GTK_IM_MODULE"]

@mattrose
Copy link
Member

mattrose commented Nov 3, 2022

Ugh, there is some conflict between IBus and Terminator broadcasting that I have been trying to track down for years now. Every time I think I have a solution, it pops back up again

@mattrose mattrose added bug Something isn't working regression used to work, now doesn't and removed question Further information is requested labels Nov 3, 2022
@shilkazx
Copy link

shilkazx commented Nov 4, 2022

Same problem after update terminator to 2.1.2-1 on Archlinux amd64. In general, delete GTK_IM_MODULE env variable would cause fcitx malfunction.

@shilkazx
Copy link

shilkazx commented Nov 4, 2022

Ugh, there is some conflict between IBus and Terminator broadcasting that I have been trying to track down for years now. Every time I think I have a solution, it pops back up again

If there is some comflict between ibus and terminator, but nothing abnormal between fcitx and terminator. Could you please temporary fix it by add a condition that check whether fcitx/ibus is used(check whether or not GTK_IM_MODULE=fcitx), and do not del the env variable in fcitx circumstance.

@mattrose mattrose added the question Further information is requested label Nov 8, 2022
@mattrose
Copy link
Member

mattrose commented Nov 8, 2022

Could you please temporary fix it by add a condition that check whether fcitx/ibus is used(check whether or not GTK_IM_MODULE=fcitx), and do not del the env variable in fcitx circumstance.

Yeah, but that wouldn't fix #670.

Have you deleted the offending lines from your code?

If so, can I ask you to run a quick test for me?

Can you try setting up broadcasting to a different terminal, and see if you get doubled characters when typing characters into the terminal?

@shilkazx
Copy link

shilkazx commented Nov 14, 2022

Could you please temporary fix it by add a condition that check whether fcitx/ibus is used(check whether or not GTK_IM_MODULE=fcitx), and do not del the env variable in fcitx circumstance.

Yeah, but that wouldn't fix #670.

Have you deleted the offending lines from your code?

If so, can I ask you to run a quick test for me?

Can you try setting up broadcasting to a different terminal, and see if you get doubled characters when typing characters into the terminal?

I'd like to try the modification I mentioned before. But could you explain the meaning of "broadcasting to a different terminal"? I've checked #670 and #78. It seems that #670 is not related to the broadcasting problem. Another thing that is worth mentioning here is I use both terminator and fcitx for such a long time, at least starting before #78 occurred, but I never met bug #78 or something like that.
Furthermore, the temporary fix I suggest before might be a semi-permanent solution. Because people who use fcitx usually focus on CJK character input but not Latin or European language, so fcitx user may rarely meet the #670 (C-cedilla) problem. Similarly, people who need C-cedilla in daily life usually do not need fcitx for CJK characters.

@mattrose
Copy link
Member

mattrose commented Nov 14, 2022

However, if I change the code so GTK_IM_MODULE=fcitx gets left in place, but all other values get removed, C-cedilla will get removed, and bug #670 will remain.

By Doubling, the screenshot at the top of #78 explains it pretty well. when you broadcast your input to multiple terminals (
https://terminator-gtk3.readthedocs.io/en/latest/grouping.html has a good guide to setting it up ), your input will be sent twice to each terminal, rather than once.

@mattrose
Copy link
Member

Can you test out the code in #674 and see if it fixes the problem

@mattrose
Copy link
Member

Should be fixed in master now.

@shilkazx
Copy link

Sorry for the late reply, I'll feedback in #674 thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested regression used to work, now doesn't
Projects
None yet
Development

No branches or pull requests

3 participants