Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a CI workflow to streamline code reviews. #687

Open
moul opened this issue Apr 2, 2023 · 1 comment
Open

Use a CI workflow to streamline code reviews. #687

moul opened this issue Apr 2, 2023 · 1 comment
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors help wanted Want to contribute? We recommend these issues.
Milestone
💡Someday/Maybe

Comments

@moul
Copy link
Member

moul commented Apr 2, 2023 •
edited
Loading

Rather than marking PRs as "blocked until we clarify" something, why not implement a CI rule that adds a comment with checkboxes to address?

While the checkboxes are not checked, the CI rule can display "waiting (orange)" and block the merge, even if it has been LGTM.

Additionally, we could simplify the PR template, which serves a similar purpose but is frequently bypassed.

Cc @zivkovicmilos, @thehowl, because you both worked on similar topics.

Related with #679.
@moul moul added 🗺️good first issue🗺️ Ideal for newcomer contributors help wanted labels Apr 2, 2023
@moul moul mentioned this issue Apr 3, 2023
Open
@moul moul moved this to 🔵 Not Needed for Launch in 🚀 The Launch [DEPRECATED] Sep 5, 2023
@moul moul added this to the 💡Someday/Maybe milestone Sep 6, 2023
@moul moul moved this to Todo in 💪 Bounties & Worx Dec 22, 2023
@0xtekgrinder
Copy link

Is this being worked on or I can take it @zivkovicmilos @thehowl ?

@Kouteki Kouteki added help wanted Want to contribute? We recommend these issues. and removed help wanted labels Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🗺️good first issue🗺️ Ideal for newcomer contributors help wanted Want to contribute? We recommend these issues.
Projects
💪 Bounties & Worx
Status: Todo
🚀 The Launch [DEPRECATED]
Status: 🔵 Not Needed for Launch
Milestone
💡Someday/Maybe
Development

No branches or pull requests
3 participants
@moul @Kouteki @0xtekgrinder