Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minimum registration fees with invites #243

Merged
merged 8 commits into from
Jun 9, 2022
Merged

chore: minimum registration fees with invites #243

merged 8 commits into from
Jun 9, 2022

Conversation

ltzmaxwell
Copy link
Contributor

@ltzmaxwell ltzmaxwell commented Jun 9, 2022 •
edited by moul
Loading

implement some TODOs;
make test pass;

fixes #238
addresses #2

moul
moul reviewed Jun 9, 2022
View reviewed changes
moul
moul requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much for your PR

can you address my suggested changes

and check why the CI is broken? (you can run the same make test.*** commands locally too)

@moul moul mentioned this pull request Jun 9, 2022
Closed
@moul moul changed the title fix pr#240 chore: minimum registration fees with invites Jun 9, 2022
@moul moul merged commit 1b60374 into gnolang:master Jun 9, 2022
@moul moul added this to the 🏗2️⃣ test2.gno.land milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🚀 The Launch [DEPRECATED]
Archived in project
Milestone
🏗2️⃣ test2.gno.land
Development

Successfully merging this pull request may close these issues.

Improve r/boards to make it the official (daily) communication tool
3 participants
@ltzmaxwell @moul @jaekwon