Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we allow smart contract access file system? It is not deterministic. #219

Closed
piux2 opened this issue May 26, 2022 · 2 comments
Closed

Should we allow smart contract access file system? It is not deterministic. #219

piux2 opened this issue May 26, 2022 · 2 comments
Milestone
🏗2️⃣ test2.gno.land

Comments

@piux2
Copy link
Contributor

piux2 commented May 26, 2022

gno/stdlibs/io/ioutil/ioutil.gno

gno/stdlibs/io/ioutil/ioutil.gno

Line 56 in 8cbba0a

func ReadDir(dirname string) ([]fs.FileInfo, error) {

gno/stdlibs/io/ioutil/ioutil.gno

Line 43 in 8cbba0a

func WriteFile(filename string, data []byte, perm fs.FileMode) error {

@piux2 piux2 changed the title Should we allow smart contract access file system? It is no deterministic. Should we allow smart contract access file system? It is not deterministic. May 26, 2022
@moul
Copy link
Member

moul commented May 27, 2022

No, we shouldn’t

Do you want to make a fix PR for this?

@piux2
Copy link
Contributor Author

piux2 commented Jun 6, 2022 •
edited
Loading

I looked at it again. the read file and directory method have already been commented out. not an issue anymore

@piux2 piux2 closed this as completed Jun 6, 2022
@moul moul added this to the 🏗2️⃣ test2.gno.land milestone Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
🚀 The Launch [DEPRECATED]
Archived in project
Milestone
🏗2️⃣ test2.gno.land
Development

No branches or pull requests
2 participants
@moul @piux2