From c8cd8f4b6ccbe9f4ee5622032228553496186d51 Mon Sep 17 00:00:00 2001 From: David Manpearl Date: Thu, 19 Dec 2024 01:56:58 -0800 Subject: [PATCH] =?UTF-8?q?fix(lint):=20fix=20'make=20install'=20failure?= =?UTF-8?q?=20due=20to=20bad=20'BeginTransaction'=20c=E2=80=A6=20(#3369)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Addresses #3368 …all in lint.io lint.go: add missing 'gasMeter' param to 'BeginTransaction' call Impact: caused 'make install' to fail on branch 'master' with the following error: cmd/gno/lint.go:147:34: not enough arguments in call to ts.BeginTransaction have ("github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".Store) want ("github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".Store, "github.com/gnolang/gno/tm2/pkg/store/types".GasMeter) make[1]: *** [install] Error 1 Testing: This fix resolves test failure commanded by `make test`: FAIL github.com/gnolang/gno/gnovm/cmd/gno [build failed] --- gnovm/cmd/gno/lint.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnovm/cmd/gno/lint.go b/gnovm/cmd/gno/lint.go index 8a1256772df..ce3465b484e 100644 --- a/gnovm/cmd/gno/lint.go +++ b/gnovm/cmd/gno/lint.go @@ -144,7 +144,7 @@ func execLint(cfg *lintCfg, args []string, io commands.IO) error { // Wrap in cache wrap so execution of the linter doesn't impact // other packages. cw := bs.CacheWrap() - gs := ts.BeginTransaction(cw, cw) + gs := ts.BeginTransaction(cw, cw, nil) // Run type checking if gmFile == nil || !gmFile.Draft {