From 40ef7205f0cf34931174995cb2cbdf1bbacfc8dc Mon Sep 17 00:00:00 2001
From: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
Date: Tue, 6 Oct 2020 08:55:51 +0300
Subject: [PATCH] [TSVB] Allow string fields on value count aggregation
 (#79267)

* [TSVB] Enable string fields for value count aggregation

* fix test title

* Allow all field types for value count aggregation

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
---
 .../components/lib/get_supported_fields_by_metric_type.js  | 1 +
 .../lib/get_supported_fields_by_metric_type.test.js        | 7 ++++++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js b/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js
index c1d7aa9d40bd..146e7a4bae15 100644
--- a/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js
+++ b/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.js
@@ -25,6 +25,7 @@ export function getSupportedFieldsByMetricType(type) {
     case METRIC_TYPES.CARDINALITY:
       return Object.values(KBN_FIELD_TYPES).filter((t) => t !== KBN_FIELD_TYPES.HISTOGRAM);
     case METRIC_TYPES.VALUE_COUNT:
+      return Object.values(KBN_FIELD_TYPES);
     case METRIC_TYPES.AVERAGE:
     case METRIC_TYPES.SUM:
       return [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM];
diff --git a/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js b/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js
index 3cd3fac191bf..4aed5348c0c1 100644
--- a/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js
+++ b/src/plugins/vis_type_timeseries/public/application/components/lib/get_supported_fields_by_metric_type.test.js
@@ -18,18 +18,23 @@
  */
 
 import { getSupportedFieldsByMetricType } from './get_supported_fields_by_metric_type';
+import { KBN_FIELD_TYPES } from '../../../../../../plugins/data/public';
 
 describe('getSupportedFieldsByMetricType', () => {
   const shouldHaveHistogramAndNumbers = (type) =>
     it(`should return numbers and histogram for ${type}`, () => {
       expect(getSupportedFieldsByMetricType(type)).toEqual(['number', 'histogram']);
     });
+  const shouldSupportAllFieldTypes = (type) =>
+    it(`should return all field types for ${type}`, () => {
+      expect(getSupportedFieldsByMetricType(type)).toEqual(Object.values(KBN_FIELD_TYPES));
+    });
   const shouldHaveOnlyNumbers = (type) =>
     it(`should return only numbers for ${type}`, () => {
       expect(getSupportedFieldsByMetricType(type)).toEqual(['number']);
     });
 
-  shouldHaveHistogramAndNumbers('value_count');
+  shouldSupportAllFieldTypes('value_count');
   shouldHaveHistogramAndNumbers('avg');
   shouldHaveHistogramAndNumbers('sum');