Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename units param to fontSizeUnits? #23

Closed
tinymachine opened this issue Feb 21, 2019 · 1 comment · May be fixed by #36
Closed

Rename units param to fontSizeUnits? #23

tinymachine opened this issue Feb 21, 2019 · 1 comment · May be fixed by #36
Labels
enhancement

Comments

@tinymachine
Copy link
Collaborator

It looks like units only applies to the minFontSize and maxFontSize settings (not the line-height settings as well, as I'd initially thought). Perhaps renaming units to fontSizeUnits would be clearer?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@tinymachine @theorosendorf