Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'make vendor-install' can lead to an infinite fork loop #195

Open
nuno-silva opened this issue Oct 12, 2021 · 0 comments · May be fixed by #197
Open

'make vendor-install' can lead to an infinite fork loop #195

nuno-silva opened this issue Oct 12, 2021 · 0 comments · May be fixed by #197

Comments

@nuno-silva
Copy link

In

gluster-prometheus/Makefile

Lines 82 to 85 in 3ebaacc

vendor-install:
@echo Installing vendored packages
@$(DEPENV) dep ensure -v -vendor-only || $(MAKE) vendor-install
@echo

@$(DEPENV) dep ensure -v -vendor-only || $(MAKE) vendor-install leads to an infinite fork loop when dep fails.
|| $(MAKE) vendor-install should be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix infinite fork loop when dep fails in 'make vendor-install' nuno-silva/gluster-prometheus
1 participant
@nuno-silva