Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace url::Url with fluent_uri::Uri<String> #266

Closed
wants to merge 2 commits into from
Closed

Replace url::Url with fluent_uri::Uri<String> #266

wants to merge 2 commits into from

Conversation

gibbz00
Copy link
Contributor

@gibbz00 gibbz00 commented Oct 6, 2023

Fixes: #261

Switch alone made it possible to identify a bug in which file://test and file://test/ were treated as the same.

@gibbz00 gibbz00 mentioned this pull request Oct 7, 2023
Closed
Marwes
Marwes requested changes Nov 22, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@Marwes Marwes mentioned this pull request Nov 22, 2023
Closed
@zebreus zebreus mentioned this pull request May 4, 2024
Closed
@matijagrcic matijagrcic mentioned this pull request May 17, 2024
Open
@gibbz00
Copy link
Contributor Author

gibbz00 commented May 19, 2024

Closing as it got merged in #282

@gibbz00 gibbz00 closed this May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marwes Marwes Marwes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider not using url crate for directory specifiers?
2 participants
@gibbz00 @Marwes