Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout options #43

Open
1 of 7 tasks
Throne3d opened this issue Feb 4, 2017 · 9 comments
Open
1 of 7 tasks

Layout options #43

Throne3d opened this issue Feb 4, 2017 · 9 comments

Comments

@Throne3d
Copy link
Contributor

Throne3d commented Feb 4, 2017

Allow layouts to be stacked with themes. So that "No Icon" can be stacked with "Starry Dark", for example.

Example layouts:

  • No Icon
  • Right-sided reply info boxes
  • Selective info in the info boxes (e.g. want character name and nickname, but not screenname or author)
  • Limit width of Constellation on wide screens
  • Show post descriptions everywhere, not just on the report page
  • Showing paginators at the top of post lists, for easier navigation
  • Show hidden status of posts in lists
@Throne3d
Copy link
Contributor Author

See discussion around here.

@dhouck
Copy link

dhouck commented Jun 10, 2017

It seems like some of these are orthogonal:

  • What info do you want in character boxes (icons? Screen name? Author name?)
  • Do you want to see reply info above/to the right of/to the left of the replies? (Would anybody want “below”? It feels weird listing three of the four standard options but I can’t see a use for the fourth)
  • From Improve the pagination display #45: How do you want pagination handled? (Although that might not be layout, which to me implies just a CSS change)

Perhaps this implies layout should be a multi-select option instead of a “choose one”, or perhaps this is really three separate features.

@Throne3d
Copy link
Contributor Author

It was intended to be a multi-select, yes. "No icon" and "Right-sided reply info boxes" should really not be mutually exclusive. The plan is to split the "No icon" type things into a layout multi-select, as distinct from the style single-select.

I don't think I was proposing to have character info above replies mostly because this would suggest that left/right overrides the current "above the reply" behavior seen on mobile.

Pagination display I was expecting to be a desktop/mobile divide, as opposed to a layout thing.

@dhouck
Copy link

dhouck commented Jun 11, 2017

Okay, I thought the plan was “One option for layout, one option for style”.

I don’t think I’m parsing your second paragraph correctly. I would like the options page to suggest putting the infobox above the reply, because I would like to actually put the infobox above the reply even on non-mobile. I don’t know what you thought would suggest it would be overridden on mobile, or whether you wanted that suggested or not, but I’m not sure how such override would work given the limited horizontal screen real estate. I think the ideal would be, on the options page, having an option for “Infobox position (non-mobile view)” with options for left, right, and above. Perhaps there could be an asterisk next to “non-mobile view” saying that the mobile view always puts the infobox above the reply.

I only mentioned #45 because it mentioned it might want to be part of this.

@Throne3d
Copy link
Contributor Author

Throne3d commented Jun 11, 2017

Oh. It would in my opinion suggest that it would override the display everywhere, if it had "Infobox above" as well as "Infobox to the right", and the problem is that yes this would be problematic on mobile devices. We could have that layout option separate from the others with such information. I had not really pictured that, though, expecting these to be together in a multiselect, but it's probably sensible for the (presumably) mutually exclusive options.

I had forgotten that I referenced this issue from there. I think I've changed my mind since then, in that case, and do not expect it to be part of this same issue. Maybe someone expressed a preference to have it toggleable at the time; I'm not sure why I would have mentioned that there.

@Marri
Copy link
Contributor

Marri commented Sep 4, 2017

So there is kinda a few things. One is that some mobile/screen size stuff crept in here, which is separate. One is what I picture as Themes, which is more "what colors are things"; this you get one of. One is layout controls, which are things like "hide all icons" and "what side do boxes go on", which should be split out from Themes and given checkboxes. And the last is stuff like screenname/character name/etc, which I am currently pretty opposed to giving reader controls for but would consider author controls.

@Throne3d
Copy link
Contributor Author

Throne3d commented Sep 4, 2017

Hmm. I don't care about screennames much, as a reader, so on mobile I've hidden them with a user style to make the boxes take up less space. I think that's a reasonable use-case?

@Marri
Copy link
Contributor

Marri commented Sep 4, 2017

That seems like a "how do we reasonably display information on mobile" question, not "the author has specified this information that we as the site team are going to choose to hide unpredictably"

@Throne3d
Copy link
Contributor Author

Throne3d commented Sep 4, 2017

… I mean, I don't think it's so much "hiding unpredictably" as "allowing users to ignore things they don't care about more easily"? I see no reason a reader shouldn't get arbitrary control over how the stuff they read is presented – it's not like it damages the author?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants