Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all extends use placeholders #1649

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make all extends use placeholders #1649

wants to merge 2 commits into from

Conversation

teceler
Copy link
Collaborator

@teceler teceler commented May 5, 2022

Fixes #1633, probably needs tested for styling consistency

@@ -126,7 +126,7 @@

/* The preview icon boxes on replace icon and replace character */
.replace-icon {
@extend .icons-box;
background-color: $bg_color_icon;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this on purpose? Doesn't seem related to the @extend at least.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to hunt for the icons-box definition but I suspect I just copied that from it

@teceler teceler force-pushed the css/placeholders branch from 858864b to 28780d3 Compare April 3, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use placeholders for extends (scss)
2 participants