Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

role_id should have default 0 #1623

Open
teceler opened this issue Feb 16, 2022 · 1 comment
Open

role_id should have default 0 #1623

teceler opened this issue Feb 16, 2022 · 1 comment

Comments

@teceler
Copy link
Collaborator

teceler commented Feb 16, 2022

https://github.com/Marri/glowfic/blob/cbb73fcff399a4d4317a4bbe5822468752f1a6b3/db/schema.rb#L455

@Throne3d
Copy link
Contributor

https://github.com/glowfic-constellation/glowfic/blob/main/app/concerns/permissible.rb#L2 doesn't seem to have a default role set up, and https://github.com/glowfic-constellation/glowfic/blob/main/app/concerns/permissible.rb#L20 seems to be expecting the default role_id to be falsy(?) which 0 wouldn't be

We can probably set up a default to 0 but I guess we want to make sure the rest of the code expects that too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants