Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to fix #758.
Motivation and Context
Currently bundles are considered for status check operations as long as they start with a given prefix. This prefix is not uniquely identifying (through the inclusion of a hash, for example), because it is meant to be short and readable. However, this can cause projects to try to read status updates from other FlowProject instances (and potentially other users) if they share a common FlowProject class name.
This fixes #758 by only considering bundles that already exist within the project.
Note: These bundle ids are guaranteed to be unique (up to hash collisions) because they include the project's filesystem path in a hash when computing the id of each
_JobOperation
. These_JobOperation
ids are then hashed together to produce a unique bundle id.I do not have a way to test this PR on a scheduler. Support from reviewers in testing would be welcome.
Checklist: