Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Optimized parameters are missing StdErr when saved to file #902

Closed
s-weigand opened this issue Nov 12, 2021 · 1 comment · Fixed by #910
Closed

🐛 Optimized parameters are missing StdErr when saved to file #902

s-weigand opened this issue Nov 12, 2021 · 1 comment · Fixed by #910
Assignees
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Milestone

Comments

@s-weigand
Copy link
Member

Version information

  • pyglotaran version: All
  • Python version: All
  • Operating System: All

Describe the bug

The optimized parameters from an analysis when saved to file are missing the StdErr, thus making the result incomplete.

To Reproduce

Run any example from the examples repo or the quickstart.

Expected behavior

The StdErr of optimized parameters is saved in the parameter file.

Screenshots

Example from the quickstart.
grafik

grafik

@s-weigand s-weigand added the Type: Bug Minor issues, non-crashing bug, slowdowns label Nov 12, 2021
@s-weigand s-weigand added this to the v0.5.0 milestone Nov 12, 2021
@s-weigand
Copy link
Member Author

This will definitely collide with the changes in #896 and might also break the result comparison (we can always update those), so it will be best to add an optional argument to ParameterGroup.to_dataframe (e.g save_std_err: bool which can also be used to differentiate between initial_parameter and optimized_parameters)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants