Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Parameters used for expressions missing in Model markdown and report #901

Closed
s-weigand opened this issue Nov 12, 2021 · 0 comments · Fixed by #914
Closed

🐛 Parameters used for expressions missing in Model markdown and report #901

s-weigand opened this issue Nov 12, 2021 · 0 comments · Fixed by #914
Assignees
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Milestone

Comments

@s-weigand
Copy link
Member

s-weigand commented Nov 12, 2021

Version information

  • pyglotaran version: All
  • Python version: All
  • Operating System: All

Describe the bug

In the markdown report, only Parameters directly used in the model are displayed, but if users define parameters only for expressions those are missing making the report incomplete.
In addition, the parameters used only show their numerical value and not the expression used to calculate them.

To Reproduce

You can edit the quickstart to use

kinetic: 
    - 0.5
    - 0.3
    - ["3", {expr: "$kinetic.expression_parameter"}]
    - ["expression_parameter", 0.1]

Instead of

kinetic: [
0.5,
0.3,
0.1,
]

For quick confirmation this can be done on binder

Expected behavior

Show expressions used to calculate parameters if they use expressions and all parameters needed to evaluate the expression.

Screenshots

The example mentioned above run in binder.
grafik
grafik

@s-weigand s-weigand added the Type: Bug Minor issues, non-crashing bug, slowdowns label Nov 12, 2021
@s-weigand s-weigand added this to the v0.6.0 milestone Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants