Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Deprecate save Result as yml #768

Closed
joernweissenborn opened this issue Aug 8, 2021 · 6 comments
Closed

🐛 Deprecate save Result as yml #768

joernweissenborn opened this issue Aug 8, 2021 · 6 comments
Assignees
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Milestone

Comments

@joernweissenborn
Copy link
Member

The problem is that it tries to serialize e.g. the covariance matrix. It would be best overwritte the state getter and setter.

@joernweissenborn joernweissenborn added the Type: Bug Minor issues, non-crashing bug, slowdowns label Aug 8, 2021
@joernweissenborn
Copy link
Member Author

Please make PR against staging and merge asap.

@s-weigand
Copy link
Member

@joernweissenborn Isn't the yml parser your baby? 😝

@joernweissenborn
Copy link
Member Author

I will fix this in in project feature

@s-weigand s-weigand added this to the v0.5.0 milestone Sep 16, 2021
@jsnel jsnel changed the title 🐛 Save Result as yml generates 100mbish ymls 🐛 Deprecate save Result as yml Sep 16, 2021
@jsnel
Copy link
Member

jsnel commented Sep 16, 2021

Saving results entirely as yml doesn't make sense, a hybrid approach is needed whereby the structure and simple properties are saved as yml but anything matrix like is saved as binary blobs (.e.g nc files) which are referenced by a path name only.

@joernweissenborn
Copy link
Member Author

So, as I see it now, we have it like this:

You give a yaml, it takes yaml. You give folder, then it will look for glotaranresult.yml in the folder and use yaml to load it. So where is the issue left?

@jsnel jsnel modified the milestones: v0.5.0, v0.6.0 Dec 3, 2021
@s-weigand
Copy link
Member

Made the preferred way to save results in #966 (now the serialized yaml only links to other files) and the folder plugin was demoted to be only used internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Minor issues, non-crashing bug, slowdowns
Projects
None yet
Development

No branches or pull requests

3 participants