Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin down version number of package dependencies #64

Closed
jsnel opened this issue Jun 26, 2017 · 2 comments
Closed

Pin down version number of package dependencies #64

jsnel opened this issue Jun 26, 2017 · 2 comments
Assignees

Comments

@jsnel
Copy link
Member

jsnel commented Jun 26, 2017

In setup.py depend on package x.y.z

We should not allow future versions in case one of our dependencies breaks their API.

@jsnel jsnel self-assigned this Jun 26, 2017
@jsnel jsnel modified the milestone: v2.0.0-alpha Aug 11, 2017
@joernweissenborn
Copy link
Member

will be fixed with #71

@joernweissenborn joernweissenborn modified the milestones: v0.1.0, v0.2.0 Aug 10, 2018
@s-weigand
Copy link
Member

s-weigand commented Sep 3, 2018

As stated in https://packaging.python.org/requirements/

It is not considered best practice to use install_requires to pin dependencies to specific versions, or to specify sub-dependencies (i.e. dependencies of your dependencies). This is overly-restrictive, and prevents the user from gaining the benefit of dependency upgrades.

pyup will take care of keeping the dev dependencies up to date, which travis and appveyor will use to generate the wheels (compiled binary packages) and run the tests.

To let pyup also take care of the install requirements there was a workaround proposed by pyupio/pyup#137 (comment) , with reading the install requirements from an extra file.

But fixing required versions might break users env.
i.e.:
glotaran requires numpy==1.14.0 and the user wants to use a pandas version that requires numpy>=1.15.0, so user gets a warning that glotaran's requirements are not met when pandas is installed last or a warning from pandas if glotaran gets installed last.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants