Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactivate 'IrfDispersion' in CI test #585

Closed
s-weigand opened this issue Mar 6, 2021 · 2 comments
Closed

Reactivate 'IrfDispersion' in CI test #585

s-weigand opened this issue Mar 6, 2021 · 2 comments
Assignees
@jsnel
Labels
Status: In Progress Issues being worked on Type: Refactor Refactoring code Type: Tooling Tools used for the project (CI, CD, docs etc.)

Comments

@s-weigand
Copy link
Member

s-weigand commented Mar 6, 2021 •
edited
Loading

Some time ago we deactivated IrfDispersion on the CI since it did lead to the CI timing out.

pyglotaran/.github/workflows/CI_CD_actions.yml

Line 112 in f214d78

pytest --cov=./ --cov-report term --cov-report xml --cov-config .coveragerc -k 'not IrfDispersion' glotaran

Since then we removed dask which did lead to huge performance improvement so the tests should pass again.
@jsnel also wanted to improve the test with sensible starting parameters so it converges quicker.
@s-weigand s-weigand added Type: Tooling Tools used for the project (CI, CD, docs etc.) Type: Refactor Refactoring code labels Mar 6, 2021
@joernweissenborn
Copy link
Member

@s-weigand is it still deactiavated? if not I not I see no reason why not to

@jsnel jsnel added the Status: In Progress Issues being worked on label Aug 13, 2021
@jsnel jsnel mentioned this issue Aug 22, 2021
Merged
3 tasks
@s-weigand
Copy link
Member Author

Closed by #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsnel jsnel

Labels
Status: In Progress Issues being worked on Type: Refactor Refactoring code Type: Tooling Tools used for the project (CI, CD, docs etc.)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joernweissenborn @jsnel @s-weigand